Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Next.js to 9.4.4 #71

Merged
merged 79 commits into from
Jul 21, 2020
Merged

Update Next.js to 9.4.4 #71

merged 79 commits into from
Jul 21, 2020

Conversation

kmjennison
Copy link
Contributor

@kmjennison kmjennison commented Jul 15, 2020

Closes #70
Addresses some items in #64

  • Update Next.js to 9.4.4
  • Use Next.js logic to add the /newtab base path
  • Use vercel dev to make the local server behave more like production
  • Add a 404 page
  • Add notes about how we handle routing and upcoming Next.js config options

@vercel
Copy link

vercel bot commented Jul 15, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gladly-team/tab-web/lihar3hai
✅ Preview: https://tab-web-git-kevin-nextjs-94.gladly-team.vercel.app

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #71 into master will decrease coverage by 4.80%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   71.32%   66.51%   -4.81%     
==========================================
  Files          64       68       +4     
  Lines         844      902      +58     
  Branches      118      124       +6     
==========================================
- Hits          602      600       -2     
- Misses        212      265      +53     
- Partials       30       37       +7     
Impacted Files Coverage Δ
src/pages/404.js 0.00% <0.00%> (ø)
src/pages/auth.js 0.00% <0.00%> (ø)
src/pages/example.js 0.00% <0.00%> (ø)
src/pages/index.js 0.00% <0.00%> (ø)
src/containers/_app.js 97.87% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757c899...09ad3be. Read the comment docs.

.gitignore Outdated
@@ -37,3 +37,5 @@ sessions
# https://github.com/whitecolor/yalc#keep-it-out-of-git
.yalc
yalc.lock

.vercel
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line


const Test = () => <div>hello!</div>

export default Test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the official Next.js base path functionality
1 participant