-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow some branding customization. #75
Conversation
@svilenmarkov Any feedback? |
Hey, thanks for contributing and sorry I didn't get back to you earlier! There's a few small things I'd like to change like replacing |
That makes sense to me. I would maybe also give a logo-type option to allow people to select either text or an image. Deciding to load text only would keep the page size down for some use cases. |
Does this include footer section also, Instead of Hiding the footer it would be nice to have an option to add any text and links |
@vishalkadam47 Yup, I've added that as well. Thanks again for contributing and sorry it took so long to get this merged! |
@svilenmarkov add one option for PWA app name, if LogoText name is long it would be nice to have an option for short name for pwa app. |
I wanted to be able to configure and disable some of the currently default branding. This pull requests adds a new top level configuration object for branding, along with several sub objects. This is tested and running fine locally for me, input is appreciated.
Branding
You can adjust the various parts of the branding through a top level
branding
property. Example:Properties
show
True will show the glance footer, false will hide it.
name
Sets the name presented after the page name in the title.
short-name
Sets the name presented before the pages in the header.