Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some branding customization. #75

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

realdavidops
Copy link
Contributor

I wanted to be able to configure and disable some of the currently default branding. This pull requests adds a new top level configuration object for branding, along with several sub objects. This is tested and running fine locally for me, input is appreciated.

Branding

You can adjust the various parts of the branding through a top level branding property. Example:

branding:
  show: true
  name: Glance
  short-name: G

Properties

Name Type Required Default
show bool no true
name string no Glance
short-name string no G

show

True will show the glance footer, false will hide it.

name

Sets the name presented after the page name in the title.

short-name

Sets the name presented before the pages in the header.

@realdavidops
Copy link
Contributor Author

@svilenmarkov Any feedback?

@svilenmarkov
Copy link
Member

Hey, thanks for contributing and sorry I didn't get back to you earlier!

There's a few small things I'd like to change like replacing short-name with logo as I'm sure most people would rather have an image there instead of a character. I'll get it sorted out and merged for the next release.

@svilenmarkov svilenmarkov added this to the v0.6.0 milestone Jun 11, 2024
@realdavidops
Copy link
Contributor Author

That makes sense to me. I would maybe also give a logo-type option to allow people to select either text or an image. Deciding to load text only would keep the page size down for some use cases.

@svilenmarkov svilenmarkov changed the base branch from main to release/v0.6.0 August 10, 2024 17:40
@vishalkadam47
Copy link

vishalkadam47 commented Aug 19, 2024

Does this include footer section also, Instead of Hiding the footer it would be nice to have an option to add any text and links

@svilenmarkov
Copy link
Member

@vishalkadam47 Yup, I've added that as well.

Thanks again for contributing and sorry it took so long to get this merged!

@svilenmarkov svilenmarkov merged commit 038794f into glanceapp:release/v0.6.0 Aug 26, 2024
@vishalkadam47
Copy link

vishalkadam47 commented Sep 13, 2024

@svilenmarkov add one option for PWA app name, if LogoText name is long it would be nice to have an option for short name for pwa app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants