Attach attributes to their associated node #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous version of the grammar, attributes essentially "floated" in the tree, meaning they were not actually attached to anything. This was causing odd issues with syntax highlighting, such as external functions marked with an `@external` attribute causing subsequent syntax highlighting to fail in source files. This commit attaches attribute nodes only to legal parent nodes (functions and statement blocks) to make syntax highlighting more consistent. Closes gleam-lang#69
deriamis
commented
Sep 19, 2023
| @@ -27,7 +27,7 @@ | |||
| }, | |||
| "homepage": "https://github.com/J3RN/tree-sitter-gleam#readme", | |||
| "dependencies": { | |||
| "nan": "^2.15.0" | |||
| "nan": "^2.18.0" | |||
There was a problem hiding this comment.
This addresses nodejs/nan#942, which causes npm install failures on some platforms.
There was a problem hiding this comment.
I'm not sure this will give tree-sitter better hints for error recovery. Plus we lose the ability to highlight attributes on their own - it's not important when parsing a complete/correct gleam file but it's a case that will come up as-you-type and if you want to show a snippet for just an attribute, like:
```gleam
@external(erlang, "erlang", "integer_to_list")
```
in a github comment for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version of the grammar, attributes essentially "floated"
in the tree, meaning they were not actually attached to anything. This
was causing odd issues with syntax highlighting, such as external
functions marked with an
@externalattribute causing subsequentsyntax highlighting to fail in source files. This commit attaches
attribute nodes only to legal parent nodes (functions and statement
blocks) to make syntax highlighting more consistent.
Closes #69