-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defining one
, other
is detected as missing keys.
#473
Comments
probably fixing #464 caused another bug. |
Yeah, there is no longer any special handling for these keys (because the previous heuristic missed some legitimate non-plural keys). One option to improve this in For now, you can work around this by adding such keys to |
I am assuming you have |
no, I'm not defining |
Interestingly, with foo:
one: One
two: Two
foo:
one: One
two: Two
three: Three no missing keys. |
How're you using this key (the |
actually, we're overwriting plus, we have specs for i18n strings. RSpec.describe I18n do
let(:i18n) { I18n::Tasks::BaseTask.new }
it do
expect(i18n.missing_keys).to be_empty
end
it do
expect(i18n.unused_keys).to be_empty
end
it do
expect(i18n.inconsistent_interpolations).to be_empty
end
end |
this is the most simple rails app including single i18n string you'll see the missing |
I'm seeing something similar when only en:
some_key:
other: this is flagged as unused
|
This bug is still in effect. shared:
addresses:
guidance:
one: "Do this"
two: "not that" To an existing locale file and got flagged as Missing translations (1) | i18n-tasks v1.0.14
+--------+---------------------------+----------------------------------+
| Locale | Key | Value in other locales or source |
+--------+---------------------------+----------------------------------+
| en | shared.addresses.guidance | other |
+--------+---------------------------+----------------------------------+ Renaming the new keys to first and second shared:
addresses:
guidance:
first: "Do this"
second: "not that" and the warning no longer appears |
with the latest i18n-tasks gem, defining those keys
then
others
are detected as missing, even when it's not actually required by application.The text was updated successfully, but these errors were encountered: