Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize and fixes missing locales #1312

Conversation

PedroAugustoRamalhoDuarte
Copy link
Contributor

Description

The goal in this issue is normalize and fixes some missing locales, for this i have done the following tasks:

  • Install i18n-tasks gem and configure for avo
  • Normalize locale files
  • Fixes inconsistent interpolations for tr locale
  • Adds missing keys for pt-BR (my main language) and ro (I used google translate for that)
  • Adds specs for no more missing keys

In this PR i do not fixes any opened issues, but we talk a little bit for this change is this PR #1216
OBS: I have not checked for unused translations, because there are a lot, i thinks this should be done in another PR.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. I run i-18n-tasks and correct one by one.
  2. Print for missing keys for pt-BR and ro locale
    Screenshot_85

@PedroAugustoRamalhoDuarte PedroAugustoRamalhoDuarte changed the title Bug/fixes missing translations Normalize and fixes missing locales Oct 13, 2022
@codeclimate
Copy link

codeclimate bot commented Oct 13, 2022

Code Climate has analyzed commit c77e751 and detected 0 issues on this pull request.

View more on Code Climate.

@PedroAugustoRamalhoDuarte
Copy link
Contributor Author

@adrianthedev i run the normalize locale again to fixes the specs, and we need to add this ignore missing i think because this bug: glebm/i18n-tasks#473:

ignore_missing:
  - 'avo.field_translations.file'
  - 'avo.field_translations.people'
  - 'avo.number_of_items'
  - 'avo.resource_translations.user'
  - 'avo.x_items_more'

@adrianthedev
Copy link
Collaborator

Ok. got it. It seemed weird having that one ignored.
Thanks for letting me know. It's ok to merge after all tasks finish.

@adrianthedev adrianthedev merged commit aaaea10 into avo-hq:main Oct 14, 2022
@PedroAugustoRamalhoDuarte PedroAugustoRamalhoDuarte deleted the bug/fixes_missing_translations branch October 14, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants