-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize and fixes missing locales #1312
Merged
adrianthedev
merged 12 commits into
avo-hq:main
from
PedroAugustoRamalhoDuarte:bug/fixes_missing_translations
Oct 14, 2022
Merged
Normalize and fixes missing locales #1312
adrianthedev
merged 12 commits into
avo-hq:main
from
PedroAugustoRamalhoDuarte:bug/fixes_missing_translations
Oct 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroAugustoRamalhoDuarte
changed the title
Bug/fixes missing translations
Normalize and fixes missing locales
Oct 13, 2022
Code Climate has analyzed commit c77e751 and detected 0 issues on this pull request. View more on Code Climate. |
@adrianthedev i run the normalize locale again to fixes the specs, and we need to add this ignore missing i think because this bug: glebm/i18n-tasks#473: ignore_missing:
- 'avo.field_translations.file'
- 'avo.field_translations.people'
- 'avo.number_of_items'
- 'avo.resource_translations.user'
- 'avo.x_items_more' |
Ok. got it. It seemed weird having that one ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal in this issue is normalize and fixes some missing locales, for this i have done the following tasks:
In this PR i do not fixes any opened issues, but we talk a little bit for this change is this PR #1216
OBS: I have not checked for unused translations, because there are a lot, i thinks this should be done in another PR.
Checklist:
Manual review steps