Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.0.14 thinks any method ending in _t is a translation method #572

Closed
mvz opened this issue May 13, 2024 · 4 comments · Fixed by #573
Closed

Version 1.0.14 thinks any method ending in _t is a translation method #572

mvz opened this issue May 13, 2024 · 4 comments · Fixed by #573
Assignees
@davidwessman

Comments

@mvz
Copy link
Contributor

mvz commented May 13, 2024

I have a method theme_t that takes a string and is used in my ERB files. With version 1.0.14, i18n-tasks has started complaining that these string arguments cannot be found in the translation files.

It seems the relevant change is e939d0e, since the changed regex matches theme_t "foo" but the original regex did not.
@davidwessman
Copy link
Collaborator

Will check it out.

@davidwessman davidwessman self-assigned this May 13, 2024
@davidwessman
Copy link
Collaborator

@mvz Could you add your config/i18n-tasks.yml?

@davidwessman davidwessman mentioned this issue May 13, 2024
Merged
davidwessman added a commit that referenced this issue May 13, 2024
@davidwessman
Uses AST-scanner for all ERB
aec6c28 
- Also fixes regex in PatternScanner to handle `theme_t "foo"` being
  marked as a translation.
- Fixes #572
davidwessman added a commit that referenced this issue May 14, 2024
@davidwessman
Uses AST-scanner for all ERB (#573)
80f9ab0 
- Also fixes regex in PatternScanner to handle `theme_t "foo"` being
  marked as a translation.
- Fixes #572
@mvz
Copy link
Contributor Author

mvz commented May 14, 2024

@davidwessman thanks for taking care of this. I missed your request but it seems it's not needed anymore.

@davidwessman
Copy link
Collaborator

@davidwessman thanks for taking care of this. I missed your request but it seems it's not needed anymore.

I figured it out, that it was not in an .html.erb but some other .erb 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwessman davidwessman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uses AST-scanner for all ERB glebm/i18n-tasks
2 participants
@mvz @davidwessman