Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search does not find locales with dashes in them #64

Closed
jessieay opened this issue Jun 4, 2014 · 5 comments
Closed

Search does not find locales with dashes in them #64

jessieay opened this issue Jun 4, 2014 · 5 comments
Labels

Comments

@jessieay
Copy link
Collaborator

jessieay commented Jun 4, 2014

We had two locales with dashes in the names.

They were both showing up when we ran i18n-tasks unused, even though they were being recognized and properly rendered in our views.

Is there a reason that, by default, locales with dashes in the names are not found?

@glebm glebm added the bug label Jun 5, 2014
glebm added a commit that referenced this issue Jun 5, 2014
@glebm
Copy link
Owner

glebm commented Jun 5, 2014

Thanks for the report! - was not on the list of valid key characters. It is now, though I would still advise against using them, at least not both _ and -.

@glebm glebm closed this as completed Jun 5, 2014
@jessieay
Copy link
Collaborator Author

jessieay commented Jun 5, 2014

Awesome! Thanks for the quick turnaround time. Now all we need is a version bump. :)

@glebm
Copy link
Owner

glebm commented Jun 5, 2014

I am getting ready to release 0.4.0, but it will take some time. Meanwhile you can use master fixed at a specific commit. Almost as good as a release!

gem 'i18n-tasks', git: 'https://github.com/glebm/i18n-tasks', ref: 'e31043d17a7f5e1fdaa6616b917e5306bce304ac'

Note that there are lots of changes since the latest release in this version, so other things might break (though the tests do pass and it works for me, just waiting for more people to try out 0.4.0.beta1 before releasing).

@glebm
Copy link
Owner

glebm commented Jun 6, 2014

v0.4.0 is out with the fix in it!

@jessieay
Copy link
Collaborator Author

jessieay commented Jun 6, 2014

awesome - thanks!! 🐶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants