Don't require spec_helper where you don't need to. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was updating my copy of the i18n spec and realized that requiring spec_helper wasn't needed to run the spec in isolation. While loading the spec_helper isn't a huge deal for this project, requiring spec_helper adds a ton of load time for many bloated projects.
|
cc/ @glebm Let me know if there is anything outstanding items/fixups needed for this PR. Excited to help out a project that has been so useful! |
|
Good catch, thank you! |
glebm
added a commit
that referenced
this pull request
Mar 24, 2015
Don't require spec_helper where you don't need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating my copy of the
I81nspec and realizedthat
require-ingspec_helperwasn't needed to run the spec in isolation.While loading the
spec_helperdoesn't add much overhead to this project,requiring
spec_helperadds a ton of load time for many bloated projects.Hope this helps!