Adds ':' to VALID_KEY_CHARS for ruby_key_literals. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is trying to install |
|
I'm looking into travis |
glebm
reviewed
Nov 1, 2016
| # both rails 4 and 5 which the gemspec supports. | ||
| require 'active_support/gem_version' | ||
|
|
||
| if ActiveSupport::VERSION::MAJOR == 5 |
There was a problem hiding this comment.
I would check for version 4 instead; Then there is a chance it will also work for Rails 6
|
Travis seems to be having a bad day (not displaying any logs), but I'll run the tests locally and release v0.9.6 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix #207
Passing build: https://travis-ci.org/jon2992/i18n-tasks/builds/172334674
This line in i18n_tasks_output_matcher was adjusted to allow non-globbing keys to print out correctly if they end in a colon. I left a comment explaining my changes in
capture_std.rb. Maybe it's just my system, but Travis also failed for that reason. It made sense to met that the tests should support ActiveSupport 4 and 5 given the support of the gem itself is that.