Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale data from dependencies: data.external #265

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Locale data from dependencies: data.external #265

merged 1 commit into from
Sep 25, 2017

Conversation

glebm
Copy link
Owner

@glebm glebm commented Sep 24, 2017

Adds a new configuration setting, data.external, for locale data from dependencies.

Locale data from dependencies is never considered unused and we never
modify it.

Fixes #264

@vsakarov PTAL

@glebm glebm added this to the v0.9.19 milestone Sep 24, 2017
Adds a new configuration setting, `data.external`, for locale data from dependencies.

Locale data from dependencies is never considered unused and we never
modify it.

Fixes #264
@vsakarov
Copy link

I like the solution, but I think is better to rename it to external_read. As there are two major things you can do with external gems: read locale data and search for usages (future enhancement).

@glebm
Copy link
Owner Author

glebm commented Sep 25, 2017

The search for usages is configured separately under search (e.g. this would be search.external), so there is no conflict.

@glebm glebm merged commit 71bc005 into master Sep 25, 2017
@glebm glebm deleted the data-external branch September 25, 2017 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants