Stop modifying locale before sending to Google Translate #558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #292 the from/to locales were modified to be limited to just the language portion of a locale tag except if it was within one of the listed set of
langague-REGION
tags. This was to fix #286.That change no longer seems to be required by the underlying API:
And maintaining that list directly in code causes several small issues, #555 #556, and #557 which actually is translating things into the incorrect language altogether.
Given that, it seems worthy of removing the vestigial locale modification code entirely and just relying on new improved behavior of the Google Translate API and EasyTranslate.