Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added not rated for templates which have unknown quality #2991

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

akanshaaa19
Copy link
Member

if a template is not rated it returns UNKNOWN, so replaced that with Not Rated

Screenshot 2024-07-22 at 7 39 48 PM

@akanshaaa19 akanshaaa19 requested a review from kurund July 22, 2024 14:10
Copy link

@github-actions github-actions bot temporarily deployed to pull request July 22, 2024 14:12 Inactive
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.98%. Comparing base (23298f6) to head (e23419c).

Files Patch % Lines
src/containers/Template/List/Template.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2991      +/-   ##
==========================================
- Coverage   80.01%   79.98%   -0.03%     
==========================================
  Files         320      320              
  Lines       10236    10236              
  Branches     2183     2183              
==========================================
- Hits         8190     8187       -3     
- Misses       1398     1399       +1     
- Partials      648      650       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jul 22, 2024

Passing run #5014 ↗︎

0 174 0 0 Flakiness 0

Details:

Merge e23419c into 23298f6...
Project: Glific Commit: a3ffa583f8 ℹ️
Status: Passed Duration: 27:00 💡
Started: Jul 22, 2024 2:20 PM Ended: Jul 22, 2024 2:47 PM

Review all test suite changes for PR #2991 ↗︎

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@kurund kurund merged commit af1cb04 into master Jul 23, 2024
11 of 13 checks passed
@kurund kurund deleted the fix/rating branch July 23, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants