Contact import automation #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-2992--glific-frontend.netlify.app |
Glific
|
||||||||||||||||||||||||||||||||||
| Project |
Glific
|
| Branch Review |
feature/bulk-contact
|
| Run status |
|
| Run duration | 25m 32s |
| Commit |
|
| Committer | Akansha Sakhre |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
168
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/notification/notification.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Notification list > downloads csv report for contact import |
Test Replay
Screenshots
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2992 +/- ##
==========================================
+ Coverage 80.25% 80.29% +0.04%
==========================================
Files 322 322
Lines 10367 10364 -3
Branches 2206 2208 +2
==========================================
+ Hits 8320 8322 +2
+ Misses 1405 1401 -4
+ Partials 642 641 -1 ☔ View full report in Codecov by Sentry. |
kurund
requested changes
Aug 27, 2024
There was a problem hiding this comment.
Overall looks good. Few suggestions:
- On clicking upload we should display the error message below Checkbox:
Are these contacts opted in?Currently, it is shown if the user check and uncheck the Checkbox. - We don't need to show additional notification as we have the message in helptext.
- If you click on Select File and hit cancel the import action is triggered. It should not.
- On the below screen close does not work. It should return to
/contact-management
- Can we add the similar notification like about for the
Move Contact.
I have also done minor clean up
…end into feature/bulk-contact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on backend PR glific/glific#3666
branch:
importContact