Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved functions to helper file #3033

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Moved functions to helper file #3033

merged 2 commits into from
Aug 20, 2024

Conversation

akanshaaa19
Copy link
Member

No description provided.

Copy link

github-actions bot commented Aug 20, 2024

@github-actions github-actions bot temporarily deployed to pull request August 20, 2024 09:32 Inactive
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.25%. Comparing base (517fa22) to head (817b8eb).
Report is 3 commits behind head on master.

Files Patch % Lines
...ations/ConversationList/ConversationList.helper.ts 91.30% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3033      +/-   ##
==========================================
- Coverage   80.29%   80.25%   -0.04%     
==========================================
  Files         321      322       +1     
  Lines       10367    10367              
  Branches     2206     2206              
==========================================
- Hits         8324     8320       -4     
- Misses       1403     1405       +2     
- Partials      640      642       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request August 20, 2024 09:44 Inactive
Copy link

cypress bot commented Aug 20, 2024



Test summary

167 0 0 0Flakiness 1


Run details

Project Glific
Status Passed
Commit 4cc7ca2 ℹ️
Started Aug 20, 2024 9:52 AM
Ended Aug 20, 2024 10:17 AM
Duration 24:48 💡
OS Linux Ubuntu -
Browser Electron 114

View run in Cypress Cloud ➡️


Flakiness

cypress/e2e/staffmanagement/StaffManagement.spec.ts Flakiness
1 Staff Management > should delete collection

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kurund kurund merged commit 14a1d1c into master Aug 20, 2024
11 of 13 checks passed
@kurund kurund deleted the refactoring branch August 20, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants