Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the input payload for updating organization flows #3049

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

akanshaaa19
Copy link
Member

fixes #3048

@akanshaaa19 akanshaaa19 self-assigned this Aug 30, 2024
Copy link

github-actions bot commented Aug 30, 2024

@github-actions github-actions bot temporarily deployed to pull request August 30, 2024 15:10 Inactive
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.26%. Comparing base (d7460c6) to head (c5c81bb).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...ettingList/OrganizationFlows/OrganizationFlows.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
- Coverage   80.29%   80.26%   -0.04%     
==========================================
  Files         322      322              
  Lines       10364    10368       +4     
  Branches     2208     2210       +2     
==========================================
  Hits         8322     8322              
- Misses       1401     1405       +4     
  Partials      641      641              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Aug 30, 2024

Glific    Run #5148

Run Properties:  status check failed Failed #5148  •  git commit 82f17104ef ℹ️: Merge cbb3e08b8c0ebe816f3c9f66b4f627b75ab19a3f into cab883c6bcce3d21d958d092a6cc...
Project Glific
Branch Review fix/org-flows
Run status status check failed Failed #5148
Run duration 26m 26s
Commit git commit 82f17104ef ℹ️: Merge cbb3e08b8c0ebe816f3c9f66b4f627b75ab19a3f into cab883c6bcce3d21d958d092a6cc...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 168
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/notification/notification.spec.ts • 1 failed test

View Output

Test Artifacts
Notification list > downloads csv report for contact import Test Replay Screenshots

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions github-actions bot temporarily deployed to pull request September 2, 2024 23:24 Inactive
@kurund kurund merged commit 44bb539 into master Sep 2, 2024
8 of 12 checks passed
@kurund kurund deleted the fix/org-flows branch September 2, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid input error on updating organization even if default flow is unchecked
2 participants