Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Separating HSM and Speed sends #3063

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

akanshaaa19
Copy link
Member

No description provided.

@akanshaaa19 akanshaaa19 added the enhancement New feature or request label Sep 4, 2024
@akanshaaa19 akanshaaa19 self-assigned this Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

@github-actions github-actions bot temporarily deployed to pull request September 4, 2024 18:17 Inactive
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 74.29078% with 145 lines in your changes missing coverage. Please review.

Project coverage is 84.54%. Comparing base (2c8b23d) to head (f7f0614).

Files with missing lines Patch % Lines
src/containers/Template/SpeedSends/SpeedSends.tsx 54.20% 93 Missing and 5 partials ⚠️
src/containers/Template/HSM/HSM.tsx 86.29% 46 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3063      +/-   ##
==========================================
- Coverage   86.14%   84.54%   -1.61%     
==========================================
  Files         323      323              
  Lines       10406    10900     +494     
  Branches     2217     2349     +132     
==========================================
+ Hits         8964     9215     +251     
- Misses       1339     1576     +237     
- Partials      103      109       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Sep 4, 2024

Glific    Run #5265

Run Properties:  status check failed Failed #5265  •  git commit 2caf64989d ℹ️: Merge f7f0614db5a7d876fb6121318bae399a2c672d03 into 2c8b23d6eeab9f4d89533c7cf9e4...
Project Glific
Branch Review templates-refactoring
Run status status check failed Failed #5265
Run duration 25m 42s
Commit git commit 2caf64989d ℹ️: Merge f7f0614db5a7d876fb6121318bae399a2c672d03 into 2c8b23d6eeab9f4d89533c7cf9e4...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 171
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/template/SpeedSend.spec.ts • 1 failed test

View Output

Test Artifacts
Speed Send > should edit speed send Test Replay Screenshots

@github-actions github-actions bot temporarily deployed to pull request September 20, 2024 18:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 21, 2024 04:23 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant