-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed form always being in disabled state #3072
Conversation
🚀 Deployed on https://deploy-preview-3072--glific-frontend.netlify.app |
Glific Run #5229
Run Properties:
|
Project |
Glific
|
Branch Review |
fix/forms
|
Run status |
Passed #5229
|
Run duration | 24m 20s |
Commit |
048da49d88 ℹ️: Merge 4da564e63e715d34b828889e6f686ca5ccca0e78 into 3588b8557ffc605f1ec43c114b3b...
|
Committer | Akansha Sakhre |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
169
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3072 +/- ##
==========================================
+ Coverage 80.26% 85.69% +5.43%
==========================================
Files 322 322
Lines 10383 10384 +1
Branches 2213 2213
==========================================
+ Hits 8334 8899 +565
+ Misses 1395 1375 -20
+ Partials 654 110 -544 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make the changes as per our discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
target issue is #3062