Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed form always being in disabled state #3072

Merged
merged 7 commits into from
Sep 10, 2024
Merged

Fixed form always being in disabled state #3072

merged 7 commits into from
Sep 10, 2024

Conversation

akanshaaa19
Copy link
Member

target issue is #3062

@akanshaaa19 akanshaaa19 self-assigned this Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

@github-actions github-actions bot temporarily deployed to pull request September 6, 2024 10:40 Inactive
Copy link

cypress bot commented Sep 6, 2024

Glific    Run #5229

Run Properties:  status check passed Passed #5229  •  git commit 048da49d88 ℹ️: Merge 4da564e63e715d34b828889e6f686ca5ccca0e78 into 3588b8557ffc605f1ec43c114b3b...
Project Glific
Branch Review fix/forms
Run status status check passed Passed #5229
Run duration 24m 20s
Commit git commit 048da49d88 ℹ️: Merge 4da564e63e715d34b828889e6f686ca5ccca0e78 into 3588b8557ffc605f1ec43c114b3b...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (3588b85) to head (4da564e).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3072      +/-   ##
==========================================
+ Coverage   80.26%   85.69%   +5.43%     
==========================================
  Files         322      322              
  Lines       10383    10384       +1     
  Branches     2213     2213              
==========================================
+ Hits         8334     8899     +565     
+ Misses       1395     1375      -20     
+ Partials      654      110     -544     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 linked an issue Sep 6, 2024 that may be closed by this pull request
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the changes as per our discussion.

@github-actions github-actions bot temporarily deployed to pull request September 9, 2024 16:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 07:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 11:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 12:05 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kurund kurund merged commit 39339ef into master Sep 10, 2024
12 of 13 checks passed
@kurund kurund deleted the fix/forms branch September 10, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Form is always in loading state if there are errors
2 participants