Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notification if maytapi phone is not active #3077

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

akanshaaa19
Copy link
Member

taget issue is glific/glific#3720
this PR is dependent on backend PR (enhancement/maytapi_status)

Copy link

github-actions bot commented Sep 10, 2024

@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 10:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 11:00 Inactive
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.10%. Comparing base (7e2772e) to head (e3369ef).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3077      +/-   ##
==========================================
+ Coverage   86.01%   86.10%   +0.08%     
==========================================
  Files         322      323       +1     
  Lines       10393    10402       +9     
  Branches     2216     2217       +1     
==========================================
+ Hits         8940     8957      +17     
+ Misses       1350     1342       -8     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Sep 10, 2024

Glific    Run #5221

Run Properties:  status check passed Passed #5221  •  git commit 871340e129 ℹ️: Merge 468df7bee6773c1d8d7528d2b7c5be207e1936b0 into 3588b8557ffc605f1ec43c114b3b...
Project Glific
Branch Review enhancement/maytapi-status
Run status status check passed Passed #5221
Run duration 24m 07s
Commit git commit 871340e129 ℹ️: Merge 468df7bee6773c1d8d7528d2b7c5be207e1936b0 into 3588b8557ffc605f1ec43c114b3b...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 11:14 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 20:38 Inactive
@kurund kurund merged commit 5808541 into master Sep 10, 2024
11 of 13 checks passed
@kurund kurund deleted the enhancement/maytapi-status branch September 10, 2024 20:47
@akanshaaa19 akanshaaa19 self-assigned this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released on staging
Development

Successfully merging this pull request may close these issues.

2 participants