Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize named blocks implementation #1106

Closed
6 tasks done
locks opened this issue May 23, 2020 · 0 comments · Fixed by #1227
Closed
6 tasks done

Finalize named blocks implementation #1106

locks opened this issue May 23, 2020 · 0 comments · Fixed by #1227
Assignees
@pzuraq

Comments

@locks
Copy link
Contributor

locks commented May 23, 2020 •
edited by pzuraq
Loading

  • Syntax error if multiple of the same named block are passed
  • Syntax error if content outside of named blocks
  • Syntax error is self-closing named block is passsed
  • else/inverse are aliases
  • else/inverse can receive block args
  • identifier must start with lowercase letter ([a-z])
@locks locks self-assigned this May 23, 2020
@locks locks assigned pzuraq and unassigned locks Dec 9, 2020
pzuraq pushed a commit that referenced this issue Dec 10, 2020
[FEAT] Finishes up named blocks
7f8b638 
Finishes up named blocks by adding tests and assertions for various edge
cases and bugs. Related:

- ember-polyfills/ember-named-blocks-polyfill#3

Fixes #1106
@pzuraq pzuraq mentioned this issue Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pzuraq pzuraq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEAT] Finishes up named blocks glimmerjs/glimmer-vm
2 participants
@locks @pzuraq