[BUGFIX] args lost when passed to {{component}} #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rreckonerr
force-pushed
the
fix/arguments-lost-when-passed-via-component-helper
branch
from
3131b5d
to
4c7b70a
Compare
Because iterator was not working as expected. `@` character was not applied to all of the @arg names in hash array, except for the first argument. It resulted in `[["@firstArg", "secondArg"], ["valOne", "valTwo"]]`, instead of `[["@firstArg", "@secondArg"], ["valOne", "valTwo"]]` Fixes emberjs/ember.js#19061
rreckonerr
force-pushed
the
fix/arguments-lost-when-passed-via-component-helper
branch
from
4c7b70a
to
b12e116
Compare
pzuraq
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
This looks great! Thank you for digging in and solving this issue, we really appreciate it! This is a great PR also, tests look fantastic, everything is solid. Going to merge right away.
@rwjblue do you think we need to backport this for Ember LTS? I'm not sure if it impacted much existing code, but may make sense to.
|
Ya, backporting seems totally fine/safe to me. In order to backport, we'd need PRs targeting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @samselikoff in emberjs/ember.js#19061,
arguments passed to {{component}} helper, except for the first one, are ignored.
Component
Resulted in
instead of