Upstream modifier tests #1271
Merged
Upstream modifier tests #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstreams modifier tests from Ember, fixing some bugs with `Object.assign` being used when it shouldn't have been. Also, converts the types for modifiers to use `Element` instead of `SimpleElement`, since the current assumption and behavior is that modifiers will only run in interactive environments with a real DOM.
pzuraq
force-pushed
the
upstream-modifier-manager-tests
branch
from
8d9f2b7
to
2c0afdd
Compare
rwjblue
reviewed
Feb 17, 2021
| @@ -23,7 +23,7 @@ export interface ModifierCapabilities extends Capabilities { | |||
| export interface ModifierManager<ModifierStateBucket> { | |||
| capabilities: ModifierCapabilities; | |||
| createModifier(factory: unknown, args: Arguments): ModifierStateBucket; | |||
| installModifier(instance: ModifierStateBucket, element: SimpleElement, args: Arguments): void; | |||
| installModifier(instance: ModifierStateBucket, element: Element, args: Arguments): void; | |||
There was a problem hiding this comment.
FWIW, I personally consider this a non-breaking change. SimpleElement is a strict subset of the Element API.
rwjblue
reviewed
Feb 17, 2021
packages/@glimmer/integration-tests/test/managers/modifier-manager-test.ts
Show resolved
Hide resolved
rwjblue
approved these changes
Feb 17, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreams modifier tests from Ember, fixing some bugs with
Object.assignbeing used when it shouldn't have been. Also, convertsthe types for modifiers to use
Elementinstead ofSimpleElement,since the current assumption and behavior is that modifiers will only
run in interactive environments with a real DOM.