[BUGFIX] Do not eagerly consume modifier args during destruction #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
bugfix/do-not-eagerly-consume-args-during-destruction
branch
2 times, most recently
from
c2cae0b
to
77a0d33
Compare
rwjblue
reviewed
Feb 24, 2021
rwjblue
reviewed
Feb 24, 2021
pzuraq
force-pushed
the
bugfix/do-not-eagerly-consume-args-during-destruction
branch
2 times, most recently
from
1bc6756
to
3dc0661
Compare
rwjblue
approved these changes
Feb 26, 2021
rwjblue
force-pushed
the
bugfix/do-not-eagerly-consume-args-during-destruction
branch
from
60f2dec
to
3dc0661
Compare
pzuraq
force-pushed
the
bugfix/do-not-eagerly-consume-args-during-destruction
branch
from
3dc0661
to
995a104
Compare
Currently, in the 3.13 modifier capabilities version, we eagerly consume the arguments that are passed to the modifier when it is destroying. This can cause issues with backtracking rerender when the state isn't actually used, and neither is the consumption. This change makes it so that we don't eagerly consume these arguments during destruction in general.
rwjblue
force-pushed
the
bugfix/do-not-eagerly-consume-args-during-destruction
branch
from
995a104
to
a6dc74b
Compare
rwjblue
deleted the
bugfix/do-not-eagerly-consume-args-during-destruction
branch
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the 3.13 modifier capabilities version, we eagerly consume
the arguments that are passed to the modifier when it is destroying.
This can cause issues with backtracking rerender when the state isn't
actually used, and neither is the consumption. This change makes it so
that we don't eagerly consume these arguments during destruction in
general.