Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix helper/modifier memory leak #1440

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix helper/modifier memory leak #1440

merged 1 commit into from
Dec 15, 2023

Commits on Dec 13, 2023

  1. Fix helper/modifier memory leak 

    By treating passing dynamic helpers and modifiers through the `ConstantsImpl`, the runtime was ensuring that they would be retained for the lifetime of the runtime. However, dynamic helpers and modifiers are often mean to have much shorter lifetimes. For example, in the case of local helpers/modifiers inside Component classes, they are often expected to be released when the component is destroyed. If the local helper/modifier is implemented by an arrow function that closes over the Component, then retaining the arrow function will also retain the component, causing the component to leak.

So, skip `ConstantsImpl` and resolve the dynamic helper/modifier directly. Note that this means these dynamic helper/modifier definitions will no longer be cache, and the dynamic helper/modifier manager lookup and invocation will happen each time the helper/modifier is resolved.
    @bendemboski
    bendemboski committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    faa2563 View commit details
    Browse the repository at this point in the history