-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tracked utilities for ember-inspector #1489
base: main
Are you sure you want to change the base?
Conversation
25ec20f
to
6e4232b
Compare
@NullVoxPopuli can we have this? |
Maybe, i'm behind an getting the VM integrated in to ember, so that's blocking me actually reviewing all these prs. At first glance though, does this need to be in production? Can we instead wrap all the behavior in meta.env? |
i think it would be nice to have it in prod as well. |
e403516
to
80c34c3
Compare
4cc0bff
to
e4a3192
Compare
79fa4e6
to
3318240
Compare
@chancancode can you have a look at this? At least i would like the object/property info on the tag for inspector |
Is there a way to make it faster? |
Maybe, nodejs creates a new hidden class whenever a new property is added to an object... Lets see if thats the cause |
6432fe4
to
6725463
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the tests!! 🎉
export { trackedData } from './lib/tracked-data'; | ||
export * from './lib/tracked-utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we export * here, should we do anything in the function implementations themselves to no-op in production?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good to me.
I don't really know what to do about production debugging, because it is handy to have a good debugging experience in production -- which we already have -- I wonder if that would be more of an opt-out in the future to have all the meta and stuff stripped in prod.
so we do not need to do this hack:
https://github.com/emberjs/ember-inspector/blob/8c4cd42a50b614981f8b863dfe07e116ced04953/ember_debug/object-inspector.js#L41