Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support modifier delegate manager in debug render tree #1589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patricklx
Copy link
Contributor

@patricklx patricklx commented Apr 30, 2024

im currently trying out ember beta which has the included modifier support for inspector, but i'm not getting an instance for e.g. did-insert modifier.
think CustomModifierManager.getDebugInstance should return the delegate

@patricklx patricklx changed the title return delegate if no modifier support modifier delegate manager in debug render tree Jun 12, 2024
@patricklx
Copy link
Contributor Author

NullVoxPopuli
NullVoxPopuli previously approved these changes Jun 12, 2024
@NullVoxPopuli
Copy link
Contributor

From @chancancode :

[rather than || delegate] we need to add a hook that custom modifier managers can implement

@patricklx
Copy link
Contributor Author

Would the hook need to be defined e.g. here: https://github.com/ember-modifier/ember-modifier/blob/ca6e654dd822f33e0ac82598ec33f61d835ccce1/ember-modifier/src/-private/class-based/modifier-manager.ts#L56
?

Wouldn't that mean that everyone would need to update their implementation?
Or update their dependency on ember/modifier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants