Get tests to pass with trace logging on #1639
Conversation
Also add back the ability to enable trace logging and disable debug assertions in the test harness.
| @@ -23,6 +23,18 @@ export async function setupQunit() { | |||
| tooltip: 'CI mode makes tests run faster by sacrificing UI responsiveness', | |||
| }); | |||
|
|
|||
| QUnit.config.urlConfig.push({ | |||
There was a problem hiding this comment.
nice -- tbh, I think we should document this on the ember guides -- gonna open an issue over there
|
duration phase estimated regression +76ms [7ms to 143ms] OR +0.59% [0.06% to 1.11%] [15:43:39] Generating Benchmark Reports [started] JSON: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/compare.json PDF: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.pdf HTML: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.html |
The opcode metadata is *useful* but it's too free-wheeling to be used for verification, which is what would ensure it stays in sync. I'm trying to move the needle on clarifying what the operand types mean, but it's a big of a slog so I'll have to do it a bit at a time.
|
Superseded by #1649 |
Also add back the ability to enable trace logging and disable debug assertions in the test harness.