Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing tests in PhantomJS 1.9 #71

Merged
merged 1 commit into from
Feb 7, 2016

Conversation

mixonic
Copy link
Member

@mixonic mixonic commented Feb 7, 2016

Is there a unified story around browser hacks like this?

Should fix the CI build for Ember.js which runs Phantom 1.9 /cc @rwjblue

(branch is named IE9, which is just incorrect)

rwjblue added a commit that referenced this pull request Feb 7, 2016
Disable failing tests in PhantomJS 1.9
@rwjblue rwjblue merged commit f235307 into glimmerjs:master Feb 7, 2016
@@ -2,6 +2,18 @@ import { Template, RenderResult } from "glimmer-runtime";
import { TestEnvironment, equalTokens, stripTight } from "glimmer-test-helpers";
import { UpdatableReference } from "glimmer-reference";

/*
* IE9 does not serialize namespaced attributes correctly. The namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phantom 1.9?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants