Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual implementation of
simple-dom
(now fully typed) is not compatible withSimple.*
. Specifically, it does not support namespaces. Removing them fromSimple.*
yields around type 20 errors:Most of these are in tests. However, I do think there is a real issue. Specifically, in SSR mode, we are wrongly assuming we can call NS methods like
createElementNS
. I don't know if this causes problems in practice – maybe a combination of things causes these things to never be called in practice, but we should get the types to more accurately reflect reality.Also, since
simple-dom
is now fully typed, and is a strict subset of DOM, do we still needSimple.*
?