Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes #2192

Merged
merged 31 commits into from
Apr 22, 2023

Conversation

ClearlyClaire
Copy link

@ClearlyClaire ClearlyClaire commented Apr 22, 2023

Conflicts

  • app/controllers/auth/setup_controller.rb:
    Upstream removed a method close to a glitch-soc theming-related method.
    Removed the method like upstream did.

Ported changes

  • d02aa27 (kinda): only one occurrence of collapsable was present in glitch-soc, which was obviously a mistake; I did not investigate as to whether the corresponding collapsible prop actually existed, though, I just applied the change
  • f05fb51
  • e5c0b16 (SCSS changes)
  • bc4745f
  • 955ec25
  • cf3fa1e
  • ab740f4

Postponed

  • 9f8d346 sounds like a good change, but glitch-soc's component is different; I haven't investigated how much of that is intentional change and how much is having missed upstream changes

nschonni and others added 29 commits April 14, 2023 11:01
Co-authored-by: luccamps <[email protected]>
Co-authored-by: Leonardo Negreiros de Oliveira <[email protected]>
Co-authored-by: Marcio Flavio <[email protected]>
Co-authored-by: Gabriel Quaresma <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Conflicts:
- `app/controllers/auth/setup_controller.rb`:
  Upstream removed a method close to a glitch-soc theming-related method.
  Removed the method like upstream did.
Port d02aa27 to glitch-soc

Signed-off-by: Claire <[email protected]>
@ClearlyClaire ClearlyClaire changed the title Glitch soc/merge upstream Merge upstream changes Apr 22, 2023
@ClearlyClaire ClearlyClaire marked this pull request as ready for review April 22, 2023 11:20
Copy link

@Plastikmensch Plastikmensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of note: 955ec25 causes Failed to load resource: the server responded with a status of 404 (Not Found) to be logged to console when entering an unused username.

bc7b339 Closes #2186

@ClearlyClaire ClearlyClaire merged commit 2ebbfeb into glitch-soc:main Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants