Fix two compiler warnings #1675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Warning 1: the type of this value must be known in this context (src/texture/any.rs:289:30) Give the raw pointer a type to fix warning that will become a hard error in future Rust releases. See rust-lang/rust#46906 * Warning 2: unused `std::result::Result` which must be used (src/context/mod.rs:528:9) Unwrap `Result` of `ops::read` just like in other invocations of this method.
|
|
These are fixed on master. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning 1: the type of this value must be known in this context
(src/texture/any.rs:289:30)
Give the raw pointer a type to fix warning that will become a hard error in
future Rust releases.
See Tracking issue for future-incompatibility lint
tyvar_behind_raw_pointerrust-lang/rust#46906Warning 2: unused
std::result::Resultwhich must be used(src/context/mod.rs:528:9)
Unwrap
Resultofops::readjust like in other invocations of this method.