Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] add option to change only the icon color #235

Closed
kiaking opened this issue Apr 5, 2023 · 0 comments · Fixed by #241
Closed

[Button] add option to change only the icon color #235

kiaking opened this issue Apr 5, 2023 · 0 comments · Fixed by #241
Assignees
@brc-dd
Labels
enhancement New feature or request

Comments

@kiaking
Copy link
Member

kiaking commented Apr 5, 2023

It would be cool if we can make button similar to what GitHub has.

Screenshot 2023-04-05 at 12 54 39

Maybe we could add :icon-mode prop for this?

interface Props {
  iconMode?: Mode
}

type Mode =
  | 'neutral'
  | 'info'
  | 'success'
  | 'warning'
  | 'danger'
@kiaking kiaking added the enhancement New feature or request label Apr 5, 2023
@brc-dd brc-dd self-assigned this Apr 6, 2023
@brc-dd brc-dd mentioned this issue Apr 6, 2023
Merged
kiaking added a commit that referenced this issue Apr 10, 2023
@brc-dd @kiaking
feat(button): add icon-mode and label-mode options (#235) (#241)
7c84109 
close #235

Co-authored-by: Kia King Ishii <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brc-dd brc-dd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(button): add icon-mode and label-mode props globalbrain/sefirot
2 participants
@kiaking @brc-dd