Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Unexpected horizontal scroll on dropdown when item text is too long #319

Closed
kiaking opened this issue Jul 20, 2023 · 2 comments · Fixed by #320
Closed

[Table] Unexpected horizontal scroll on dropdown when item text is too long #319

kiaking opened this issue Jul 20, 2023 · 2 comments · Fixed by #320
Labels
bug Something isn't working

Comments

@kiaking
Copy link
Member

kiaking commented Jul 20, 2023

We get this horizontal scroll effect.

Screenshot 2023-07-20 at 15 55 49

This only happens on <STable>. If we use <SDropdown> or <SInputDropdown>, the long text gets wrapped. It should behave the same for table too.

@kiaking kiaking added the bug Something isn't working label Jul 20, 2023
@brc-dd
Copy link
Member

brc-dd commented Jul 20, 2023

Any idea why this was added?

white-space: nowrap;

Removing/reseting it would fix this.

@kiaking
Copy link
Member Author

kiaking commented Jul 20, 2023

Hmmm that is added for .table class so probably for table's horizontal scrolling...? But why is that style leaking into dropdown 🤔 ?

Though, without looking into the details, if removing that wouldn't break table's horizontal scroll feature, I think we can remove that one 👍

Or, to avoid this happening on other places, maybe it's safer to explicitly add white-space rule in dropdown component so that it doesn't get overridden by its parent 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants