chore: enable corepack #205
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 67.98% // Head: 67.98% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 67.98% 67.98%
=======================================
Files 105 105
Lines 8402 8402
Branches 328 328
=======================================
Hits 5712 5712
Misses 2690 2690 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Might wanna remove pnpm version from test workflow too. |
kiaking
approved these changes
Jan 25, 2023
cuebit
approved these changes
Jan 25, 2023
brc-dd
approved these changes
Jan 25, 2023
ryo-gk
approved these changes
Jan 25, 2023
|
I've removed pnpm version from GitHub workflow 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that no package manager and its version are specified in the code base.
I believe it's reasonable to specify
packageManagerfield inpackage.jsonand to use corepack, so that everyone can use same version of same package manager always.I set everyone as reviewers to hear what you think, or just notification purpose.