-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(desc): empty slot not showing empty state #328
Conversation
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 84.47% 84.51% +0.04%
==========================================
Files 139 139
Lines 11127 11156 +29
Branches 492 630 +138
==========================================
+ Hits 9400 9429 +29
Misses 1727 1727
☔ View full report in Codecov by Sentry. |
Looking at the tests, this will also treat |
@brc-dd Haven't tested but I think so...? At the moment, either way works in that case since we don't have that use case 😅 |
I found that currently, if we pass null value to
<SDesc>
slots, it will not render<SDEscEmpty>
. This PR fixes it by checking in the actual slot contents.I've also added helper utilities to do this as well.