-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(table): add option to control display count of avatars (#416) #417
Conversation
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Divyansh Singh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
By the way, I agree with @brc-dd's suggestion.
yeah looks better I guess |
Haha, yeah this is tough one. Also GitHub avatars keep squashing as numbers grow. Somewhat interesting way to handle the "+1" part I think 👀 I guess we can keep it as-is. I think it is more important to show the full avatars so that we can recognize who those are 😳 |
sounds good. |
STableCellAvatars
#416Now we can control how many avatars do we wanna show on table cell. We can also set count to
0
to hide avatars or names.