Do not notify report updates when personal notes are loaded

globaleaks · Jun 1, 2024 · 709b330 · 709b330
1 parent 8c2261a
commit 709b330
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/backend/globaleaks/jobs/notification.py b/backend/globaleaks/jobs/notification.py
@@ -108,9 +108,12 @@ def generate(self, session):
         for user, rtip, itip, obj in itertools.chain(results1, results2, results3):
             tid = user.tid
 
-            if (rtips_ids.get(rtip.id, False) or tid in silent_tids) or \
-               (isinstance(obj, models.Comment) and obj.author_id == user.id) or \
-               (rtip.last_notification > rtip.last_access):
+            if (tid in silent_tids) or \
+                rtips_ids.get(rtip.id, False) or \
+                rtip.last_notification > rtip.last_access or \
+                (isinstance(obj, models.Comment) and \
+                 (obj.author_id == user.id or
+                  obj.visibility == models.EnumVisibility.personal.name)):
                 obj.new = False
                 continue