Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Definition of Acre as 'state' rather than territory #708

Closed
wants to merge 1 commit into from

Conversation

cathal444
Copy link
Contributor

Fixes #533

-Rather than keep the old Synset for 'Acre' and create a new one, it seems more appropriate to update the existing definition and adjust the relations accordingly.

Fixes globalwordnet#533

-Rather than keep the old Synset for 'Acre' and create a new one, it seems more appropriate to update the existing definition and adjust the relations accordingly.
@arademaker
Copy link
Member

I am not sure about the final solution. I would think we lost information with this approach because in many texts Acre will be a territory... This is also related to #712. How can we keep track of changes in senses? I reasonable solution can be to just add new senses.

@jmccrae
Copy link
Member

jmccrae commented Aug 5, 2021

@cathal444 I think this is the wrong hypernym ewn-08185877-n is the synset for 'state, nation'. It should be ewn-08671935-n

@arademaker We still have the information that Acre is a territory as the synset for 'state' is a hyponym of the synset for 'territory'. A state is just a more specific kind of territory.

On the question of tracking changes of senses (this should probably be discussed in separate issue), OEWN is a dictionary of modern English and there are no plans to model diachronic changes in meaning. For factual, encyclopedic facts, I would say the best is to model the current situation.

@arademaker
Copy link
Member

Fine. We just need to be consistent. If that is the decision, maybe we can find other cases where two senses differ only by temporal use.

@arademaker
Copy link
Member

BTW, I didn't notice that territory is hyper of state. Thank you.

@jmccrae jmccrae closed this Aug 13, 2021
@arademaker arademaker mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If Acre is a territory all other 26 states of Brazil should also be
3 participants