Fix #902: Update version year #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to move #902 along. This PR changes the
versionfrom2021to2022in bothmerge.pyandwordnet_yaml.py. The resulting XML file passes bothxmllintandvalidate.py.In producing this PR, I noticed a few opportunities for improved documentation:
pyyamlis a dependency, but it is not mentioned anywhere and there is norequirements.txtCONTRIBUTING.mdis missing thefrom-yaml.pystep for building the XML (it is mentioned in the README, however)CONTRIBUTING.mdandREADME.mdboth refer town31.xmlinstead ofwn.xmlI'm happy to push a commit to address these issues but they are not directly relevant to this PR.