Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rendering REQ-VIDEO-LAYOUT in stream info classes #365

Merged

Conversation

colekas-ssim
Copy link
Contributor

REQ-VIDEO-LAYOUT is a relatively new tag within a stream info class - https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis#section-4.4.3.8 (Page 48)

Copy link
Member

@mauricioabreu mauricioabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@leandromoreira leandromoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the tag in the readme?

@mauricioabreu
Copy link
Member

@leandromoreira it is not a tag per se, it is a stream info attribute

@colekas-ssim
Copy link
Contributor Author

colekas-ssim commented May 14, 2024

I can add something to the README.rst, but it doesn't look like it has a section for these types of additions... open to suggestions.

@mauricioabreu
Copy link
Member

@colekas-ssim no need to. We currently just document tags, not specific attributes of each tag.

Thank you, merging!

@mauricioabreu mauricioabreu merged commit c740cc0 into globocom:master May 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants