Remove code that checks if the user is in a TTY #1722
+17
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-janidlo
added
the
no-news-is-good-news
|
Cross-ref: globus/globus-sdk-python#1093 |
rjmello
reviewed
Nov 14, 2024
khk-globus
previously approved these changes
Nov 14, 2024
chris-janidlo
force-pushed
the
remove-tty-checks
branch
from
6c26e7f
to
6896517
Compare
`globus-sdk==3.47.0` handles this class of errors for us by informing users on what to do when `input` receives `EOFError` during login flows.
chris-janidlo
force-pushed
the
remove-tty-checks
branch
from
6896517
to
7f0684d
Compare
|
(fixed merge conflict) |
khk-globus
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
globus-sdk==3.47.0handles this class of errors for us by informing users on what to do wheninputreceivesEOFErrorduring login flows.[sc-37236]
Type of change