fix(Authorization): The value of the 'required_scopes' property of an AuthorizationError is now sent to Globus Auth as 'scope' parameter by default. #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbottigliero
force-pushed
the
fix-request_scopes-mapping
branch
2 times, most recently
from
29efb5c
to
a3abe0a
Compare
… AuthorizationError is now sent to Globus Auth as 'scope' parameter by default.
jbottigliero
force-pushed
the
fix-request_scopes-mapping
branch
from
a3abe0a
to
b2e7db6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 68 68
Lines 1162 1163 +1
Branches 180 180
=======================================
+ Hits 1151 1152 +1
Misses 11 11 ☔ View full report in Codecov by Sentry. |
jbottigliero
requested review from
theroncross,
becca-palmer and
pbak-globus
jbottigliero
pushed a commit
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [5.1.1](v5.1.0...v5.1.1) (2024-11-13) ### Bug Fixes * **Authorization:** The value of the 'required_scopes' property of an AuthorizationError is now sent to Globus Auth as 'scope' parameter by default. ([#366](#366)) ([66e5c32](66e5c32)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses situations where
AuthorizationManager.handleAuthorizationErroror.handleErrorwas being used and not requesting the proper scopes by default.