-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dumping only part of the buffer for burst writer. #1870
Merged
+173
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbridley
reviewed
Aug 18, 2024
janbridley
approved these changes
Aug 18, 2024
When the whole buffer is not cleared, only part of the buffer up until the last frame that was written is cleared instead
janbridley
reviewed
Aug 21, 2024
janbridley
reviewed
Aug 21, 2024
janbridley
reviewed
Aug 21, 2024
joaander
requested changes
Aug 21, 2024
janbridley
approved these changes
Aug 23, 2024
joaander
added
the
validate
Execute long running validation tests on pull requests
label
Aug 26, 2024
joaander
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds 3 options to dump function of burst writer: start, stop and clear buffer. Start and stop determine which subset of frames will be dumped, while clear buffer flag clears the buffer or not. Default options should give same results as the current implementation.
Motivation and context
This would be very useful to have for interactivity with dupin where often we just want to dump a subset of the deque buffer of dump writer.
How has this been tested?
Tests testing new functionality have been added.
Change log
Checklist:
sphinx-doc/credits.rst
) in the pull request source branch.