Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation of create_access_module method #308

Merged
merged 20 commits into from
Apr 3, 2020
Merged

Deprecation of create_access_module method #308

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5245289
Deprecated create_access_module method
kidrahahjo Mar 19, 2020
2a7de76
Hardik Ojha added to contributors.yaml
kidrahahjo Mar 19, 2020
3e0d8d5
Deprecated Access Modules
kidrahahjo Mar 20, 2020
0d4c12e
Hide warning for deprecated method creare_access_module
kidrahahjo Mar 21, 2020
44ebcf9
Merge remote-tracking branch 'upstream/master' into access_deprecation
kidrahahjo Mar 21, 2020
1b85026
Merge branch 'master' into access_deprecation
bdice Mar 30, 2020
ba490af
Moved changelog entry to next.
bdice Mar 30, 2020
c079c40
Emit warnings in __main__ entrypoint.
bdice Mar 31, 2020
a8f070a
Use private method instead of deprecated public method _find_job_ids.
bdice Mar 31, 2020
e11eced
Don't check for deprecation warning in subprocess.
bdice Mar 31, 2020
5c80834
Add deprecated_in_version function.
bdice Mar 31, 2020
610826c
Add changelog line about CLI warnings.
bdice Mar 31, 2020
8cf182f
Updated branch with origin
kidrahahjo Apr 1, 2020
88f0bee
Update branch with origin
kidrahahjo Apr 1, 2020
b8a64f6
Synced with origin
kidrahahjo Apr 1, 2020
fe85f22
Merge branch 'access_deprecation' of https://github.com/kidrahahjo/si…
bdice Apr 2, 2020
bb90b92
Use project.id instead of project.get_id().
bdice Apr 2, 2020
8fd6428
Merge branch 'master' into access_deprecation
bdice Apr 2, 2020
71d3757
Unnecessary changes reverted
kidrahahjo Apr 3, 2020
d910eb7
Merge branch 'master' into access_deprecation
bdice Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contributors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,8 @@ contributors:
family-names: Chandra
given-names: Abhavya
affiliation: "Indian Institute of Technology, Gandhinagar"
-
family-names: Ojha
given-names: Hardik
affiliation: "Indian Institute of Technology Roorkee"
...
3 changes: 3 additions & 0 deletions signac/contrib/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1448,6 +1448,9 @@ class Crawler(SignacProjectCrawler):
for doc in docs:
yield doc

@deprecated(
deprecated_in="1.4", removed_in="2.0", current_version=__version__,
details="Uses deprecated functionality")
bdice marked this conversation as resolved.
Show resolved Hide resolved
def create_access_module(self, filename=None, master=True):
"""Create the access module for indexing
Expand Down