Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on pytest-subtests. #379

Merged
merged 5 commits into from
Sep 9, 2020
Merged

Conversation

bdice
Copy link
Member

@bdice bdice commented Aug 26, 2020

Description

This PR changes a small number of tests that relied on the pytest-subtests plugin.

Motivation and Context

The pytest-subtests plugin was causing some trouble because upgrades to pytest broke compatibility with pytest-subtests on two separate occasions:

  1. 0.3.1 to 0.3.2 breakage is documented here: Bump pytest from 5.4.3 to 6.0.1 #366, Bump pytest from 5.4.3 to 6.0.1 #366 (comment).
  2. 0.3.0 to 0.3.1 breakage is not documented but I remember running into it on my own, and found a comment to corroborate this on Slack.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@bdice bdice requested review from a team as code owners August 26, 2020 14:28
@bdice bdice requested review from csadorf and klywang and removed request for a team August 26, 2020 14:28
@bdice bdice self-assigned this Aug 26, 2020
@bdice bdice added dependencies Pull requests that update a dependency file enhancement New feature or request labels Aug 26, 2020
@bdice bdice added this to the v1.5.0 milestone Aug 26, 2020
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #379 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   76.49%   76.46%   -0.03%     
==========================================
  Files          45       45              
  Lines        7130     7130              
==========================================
- Hits         5454     5452       -2     
- Misses       1676     1678       +2     
Impacted Files Coverage Δ
signac/contrib/project.py 91.32% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba4465a...af3295c. Read the comment docs.

tests/test_project.py Outdated Show resolved Hide resolved
tests/test_project.py Outdated Show resolved Hide resolved
@bdice
Copy link
Member Author

bdice commented Sep 7, 2020

@klywang Can you please review?

tests/test_project.py Outdated Show resolved Hide resolved
Copy link
Contributor

@klywang klywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@bdice bdice merged commit 9cec91e into master Sep 9, 2020
@bdice bdice deleted the feature/remove-pytest-subtests branch September 9, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants