-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock lazy properties #529
Lock lazy properties #529
Conversation
Maybe not in this PR -- But can we add some tests so we can catch any regressions RE thread safety? |
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
==========================================
+ Coverage 78.17% 78.27% +0.09%
==========================================
Files 65 65
Lines 7039 7069 +30
Branches 1311 1311
==========================================
+ Hits 5503 5533 +30
Misses 1231 1231
Partials 305 305
Continue to review full report at Codecov.
|
I think this is a good idea. I've done extensive work to make synced collections thread safe, and there are tests for that, but the thread safety of job objects is far less tested. I'll make an issue for it. |
Description
While debugging #528, we identified two sets of changes that are needed for correctness.
This PR adds thread locks around Job and Project methods that lazily instantiate synced collections and HDF5 data stores.
Motivation and Context
Fixes thread safety in Job and Project classes.
Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist:
If necessary: