Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JobSearchIndex (unused class). #587

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Remove JobSearchIndex (unused class). #587

merged 1 commit into from
Aug 10, 2021

Conversation

bdice
Copy link
Member

@bdice bdice commented Aug 2, 2021

Description

Remove unused JobSearchIndex class.

This class isn't used and is untested. I think it can be removed without any issue. However, we may wish to deprecate this class in signac 1.8 for good measure.

Motivation and Context

signac 2.0 cleanup.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@bdice bdice requested review from a team as code owners August 2, 2021 01:58
@bdice bdice requested review from vyasr and emilybwsiew and removed request for a team August 2, 2021 01:58
@bdice bdice changed the base branch from master to next August 2, 2021 01:58
@bdice bdice added this to the v2.0.0 milestone Aug 2, 2021
@bdice bdice added the requires-1.x-deprecation Changes for 2.0 that require a deprecation to be added in 1.x. label Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #587 (1d36212) into next (c6e059e) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #587      +/-   ##
==========================================
+ Coverage   82.41%   82.62%   +0.21%     
==========================================
  Files          54       54              
  Lines        5845     5824      -21     
  Branches     1097     1090       -7     
==========================================
- Hits         4817     4812       -5     
+ Misses        785      769      -16     
  Partials      243      243              
Impacted Files Coverage Δ
signac/contrib/project.py 87.66% <ø> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e059e...1d36212. Read the comment docs.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can you make a PR to deprecate this on master before we merge this PR? I don't want to lose track of that.

@bdice
Copy link
Member Author

bdice commented Aug 6, 2021

For consistency, can you make a PR to deprecate this on master before we merge this PR? I don't want to lose track of that.

I’m tracking those with the label requires-1.x-deprecation and am planning to do follow-up work that handles those deprecations for a number of these removals at once.

@bdice bdice requested a review from vyasr August 6, 2021 16:54
@bdice bdice mentioned this pull request Aug 10, 2021
12 tasks
@bdice
Copy link
Member Author

bdice commented Aug 10, 2021

@vyasr I created #600 for the corresponding deprecation of this class.

@bdice bdice merged commit 7e2f37b into next Aug 10, 2021
@bdice bdice deleted the remove/JobSearchIndex branch August 10, 2021 13:53
vyasr pushed a commit that referenced this pull request Nov 9, 2021
bdice added a commit that referenced this pull request Dec 5, 2021
vyasr pushed a commit that referenced this pull request Dec 25, 2021
vyasr pushed a commit that referenced this pull request Jan 4, 2022
vyasr pushed a commit that referenced this pull request Jan 27, 2022
vyasr pushed a commit that referenced this pull request Feb 4, 2022
vyasr pushed a commit that referenced this pull request Feb 21, 2022
vyasr pushed a commit that referenced this pull request Feb 21, 2022
vyasr pushed a commit that referenced this pull request Mar 14, 2022
vyasr pushed a commit that referenced this pull request Apr 19, 2022
vyasr pushed a commit that referenced this pull request Apr 21, 2022
vyasr pushed a commit that referenced this pull request May 2, 2022
bdice added a commit that referenced this pull request Jun 14, 2022
bdice added a commit that referenced this pull request Aug 1, 2022
bdice added a commit that referenced this pull request Oct 7, 2022
bdice added a commit that referenced this pull request Oct 27, 2022
vyasr pushed a commit that referenced this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-1.x-deprecation Changes for 2.0 that require a deprecation to be added in 1.x.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants