-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JobSearchIndex (unused class). #587
Conversation
Codecov Report
@@ Coverage Diff @@
## next #587 +/- ##
==========================================
+ Coverage 82.41% 82.62% +0.21%
==========================================
Files 54 54
Lines 5845 5824 -21
Branches 1097 1090 -7
==========================================
- Hits 4817 4812 -5
+ Misses 785 769 -16
Partials 243 243
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, can you make a PR to deprecate this on master before we merge this PR? I don't want to lose track of that.
I’m tracking those with the label |
Description
Remove unused JobSearchIndex class.
This class isn't used and is untested. I think it can be removed without any issue. However, we may wish to deprecate this class in signac 1.8 for good measure.
Motivation and Context
signac 2.0 cleanup.
Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist:
If necessary: