Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused error classes. #595

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Remove unused error classes. #595

merged 2 commits into from
Aug 9, 2021

Conversation

bdice
Copy link
Member

@bdice bdice commented Aug 6, 2021

Description

Removes unused error classes from signac 2.0.

Motivation and Context

signac 2.0 API cleanup.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@bdice bdice added this to the v2.0.0 milestone Aug 6, 2021
@bdice bdice added the requires-1.x-deprecation Changes for 2.0 that require a deprecation to be added in 1.x. label Aug 6, 2021
@bdice bdice self-assigned this Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #595 (0ec5108) into next (579800d) will decrease coverage by 0.75%.
The diff coverage is 92.30%.

❗ Current head 0ec5108 differs from pull request most recent head e0b9217. Consider uploading reports for the commit e0b9217 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             next     #595      +/-   ##
==========================================
- Coverage   84.76%   84.00%   -0.76%     
==========================================
  Files          52       53       +1     
  Lines        5264     5327      +63     
  Branches      964      980      +16     
==========================================
+ Hits         4462     4475      +13     
- Misses        587      635      +48     
- Partials      215      217       +2     
Impacted Files Coverage Δ
signac/__main__.py 75.17% <0.00%> (ø)
signac/contrib/utility.py 51.88% <ø> (-16.61%) ⬇️
signac/contrib/project.py 86.22% <100.00%> (ø)
signac/errors.py 92.30% <100.00%> (ø)
signac/contrib/linked_view.py 83.91% <0.00%> (-4.24%) ⬇️
signac/contrib/schema.py 95.48% <0.00%> (-0.76%) ⬇️
signac/contrib/collection.py 83.82% <0.00%> (-0.61%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579800d...e0b9217. Read the comment docs.

Base automatically changed from remove-project-index to next August 6, 2021 16:23
@bdice bdice marked this pull request as ready for review August 6, 2021 16:23
@bdice bdice requested review from a team as code owners August 6, 2021 16:23
@bdice
Copy link
Member Author

bdice commented Aug 9, 2021

@csadorf Sorry, I hadn't rebased this branch correctly at the time you reviewed. I fixed that now and will merge once tests pass.

@bdice bdice enabled auto-merge (squash) August 9, 2021 14:11
@bdice bdice merged commit ee65b82 into next Aug 9, 2021
@bdice bdice deleted the remove-errors branch August 9, 2021 14:36
vyasr pushed a commit that referenced this pull request Nov 9, 2021
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
bdice added a commit that referenced this pull request Dec 5, 2021
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
vyasr pushed a commit that referenced this pull request Dec 25, 2021
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
vyasr pushed a commit that referenced this pull request Jan 4, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
vyasr pushed a commit that referenced this pull request Jan 27, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
vyasr pushed a commit that referenced this pull request Feb 4, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
vyasr pushed a commit that referenced this pull request Feb 21, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
vyasr pushed a commit that referenced this pull request Feb 21, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
vyasr pushed a commit that referenced this pull request Mar 14, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
vyasr pushed a commit that referenced this pull request Apr 19, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
vyasr pushed a commit that referenced this pull request Apr 21, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
vyasr pushed a commit that referenced this pull request May 2, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
bdice added a commit that referenced this pull request Jun 14, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
bdice added a commit that referenced this pull request Aug 1, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
bdice added a commit that referenced this pull request Oct 7, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
bdice added a commit that referenced this pull request Oct 27, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
vyasr pushed a commit that referenced this pull request Oct 30, 2022
* Remove unused error classes.

* Remove AuthenticationError, ExportError, FetchError.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-1.x-deprecation Changes for 2.0 that require a deprecation to be added in 1.x.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants