-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove index arguments and state point backups #599
Conversation
b727cb6
to
ed75130
Compare
Codecov Report
@@ Coverage Diff @@
## next #599 +/- ##
==========================================
+ Coverage 85.32% 85.52% +0.19%
==========================================
Files 52 52
Lines 5207 5120 -87
Branches 957 928 -29
==========================================
- Hits 4443 4379 -64
+ Misses 551 540 -11
+ Partials 213 201 -12
Continue to review full report at Codecov.
|
f694714
to
df77da6
Compare
e079197
to
d3ee9e4
Compare
93ef230
to
f51ff14
Compare
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
* Remove index argument from _find_job_ids and CLI. * Remove index argument from linked views. * Remove access modules. * Remove index argument from detect_schema. * Improve docstrings. * Remove unused _read_index function. * Use generator in the same line it is constructed; remove unclear variable name jsi. * Rename sp_index to statepoint_index. * Remove index argument from repair method. * Clarify docstrings. * Remove index from docstring. * Remove deprecated state point backup functions. * Remove docs for removed methods. * Fix tests for repair function to use only the persistent cache. * Remove public get_statepoint method. * Remove error. * Improve rigor of state point validation after repair. * Clarify docstring notes.
Description
Additional cleanup related to #588. This PR removes
index
arguments from a number of methods ofProject
and the CLI.I also removed the public methods
read_statepoints
,write_statepoints
, anddump_statepoints
from the public API (see #579).Finally, I removed the deprecated function
get_statepoint
from the public API because it usedFN_STATEPOINTS
which was removed as a part of the previously mentionedread/write/dump_statepoints
changes. I would have split this into two pull requests but there would have been a couple annoying merge conflicts. Since this is a pure removal, I thought it would be fine to combine the two sets of changes to avoid having to deal with the conflicts.Deprecations for the
index
argument will need to be added to signac 1.x.Motivation and Context
signac 2.0 API cleanup. There is no longer a public method for generating an index, so it no longer makes sense to allow users to supply one as an argument.
Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist:
If necessary: