Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove groupbydoc. #601

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Remove groupbydoc. #601

merged 1 commit into from
Aug 16, 2021

Conversation

bdice
Copy link
Member

@bdice bdice commented Aug 10, 2021

Description

Remove deprecated groupbydoc method and consolidate tests.

Motivation and Context

signac 2.0 API cleanup.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@bdice bdice requested review from a team as code owners August 10, 2021 21:57
@bdice bdice added this to the v2.0.0 milestone Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #601 (02a5a5d) into next (6290256) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #601      +/-   ##
==========================================
- Coverage   85.78%   85.77%   -0.01%     
==========================================
  Files          52       52              
  Lines        5099     5075      -24     
  Branches      921      914       -7     
==========================================
- Hits         4374     4353      -21     
+ Misses        524      522       -2     
+ Partials      201      200       -1     
Impacted Files Coverage Δ
signac/contrib/project.py 88.29% <ø> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6290256...02a5a5d. Read the comment docs.

@bdice bdice self-assigned this Aug 16, 2021
@bdice bdice merged commit 8b9adbd into next Aug 16, 2021
@bdice bdice deleted the remove-groupbydoc branch August 16, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants