-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate project id #644
Deprecate project id #644
Conversation
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
==========================================
- Coverage 78.56% 78.54% -0.02%
==========================================
Files 65 65
Lines 7137 7141 +4
Branches 1564 1565 +1
==========================================
+ Hits 5607 5609 +2
- Misses 1227 1228 +1
- Partials 303 304 +1
Continue to review full report at Codecov.
|
@cbkerr @Tobias-Dwyer will you have time to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also have to update the docstring of init_project
on line 3045?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check that my changes to init_project
on lines 3046 and 3055 are okay.
Otherwise it looks good!
Still waiting on #643. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Projects now have a default name, and setting any custom name triggers a warning.
Motivation and Context
Related to #541. This change provides a softer off-ramp for current users with scripts where they provide the name parameter for project initialization. Rather than removing it entirely, this PR provides a warning that this parameter will be removed in 2.0.
Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist:
If necessary: